Music: fix for infinite loop when loop field cleared #48877
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the "by" field was cleared, an infinite loop would occur, due to the generated code including something like this:
The issue is subtle, but it turns out that
Blockly.JavaScript.valueToCode
was returning'0'
, and while'0' == false
might betrue
,'0' || '1'
will return'0'
.The simple fix here is to use the unary plus operator to convert the
'0'
to0
. Then we will fall back to'1'
when the field is blank.