Revert "Add CSP and CSA eyes test coverage for PD Teacher Application" #49017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hannahbergam
approved these changes
Nov 4, 2022
| @@ -100,7 +145,33 @@ Scenario: Teacher saves, re-opens, and submits an application | |||
| And I see no difference for "Viewing previously-saved teacher application" | |||
|
|
|||
| # Finish application to submit it | |||
| And I complete Section 1 of the teacher PD application | |||
| And I press keys "Snape" for element "input#lastName" | |||
There was a problem hiding this comment.
I have to say- it was very satisfying to see "Severus" and "Snape" appear during that Saucelabs run😂. That said- approved. I've had to add a no_mobile exclusion on ui tests before- do we have any idea how many teachers submit applications on mobile?
There was a problem hiding this comment.
Yes! And the principal is Dumbledore :) I may have to do that as well, but I'm going to look into it first just in case, and I don't know how many sorry :/
There was a problem hiding this comment.
Thank you for the quick review!
TurnerRiley
deleted the
revert-48897-update-teacher-app-ui-tests-csp-csa-coverage
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #48897 due to eyes test issues specific to iPhones and iPads: https://app.saucelabs.com/tests/413a4c5aec0041d38ea78c9a8cf3ca65#73