Show Workshop Exit Survey for Yearlong PLCs #49409
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per this Zendesk ticket and this Slack thread, teachers in yearlong workshops were not able to view the element containing the button to send them to the post-workshop survey. A valid link is confirmed created and emailed to them, but their Professional Learning pages would not show the button sending them to said link.
The issue came up because it turns out
self.filter_for_survey_completion
inenrollment.rb
was intentionally filtering out those courses. This PR updates this logic so that any workshops with surveys show that button.Original behavior with missing button:
New behavior with button:
Links
Jira task: here
Threads where issue was discussed: here first and here second
Testing story
Updated unit tests, local + adhoc testing, and drone tests.
PR Checklist: