Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show Workshop Exit Survey for Yearlong PLCs #49409

Merged
merged 6 commits into from
Dec 15, 2022

Conversation

TurnerRiley
Copy link
Contributor

@TurnerRiley TurnerRiley commented Dec 8, 2022

As per this Zendesk ticket and this Slack thread, teachers in yearlong workshops were not able to view the element containing the button to send them to the post-workshop survey. A valid link is confirmed created and emailed to them, but their Professional Learning pages would not show the button sending them to said link.

The issue came up because it turns out self.filter_for_survey_completion in enrollment.rb was intentionally filtering out those courses. This PR updates this logic so that any workshops with surveys show that button.

Original behavior with missing button:

No Survey Link

New behavior with button:

Yearlong WORKS

Links

Jira task: here
Threads where issue was discussed: here first and here second

Testing story

Updated unit tests, local + adhoc testing, and drone tests.

PR Checklist:

  • Tests provide adequate coverage
  • Privacy and Security impacts have been assessed
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

@TurnerRiley TurnerRiley changed the base branch from staging-next to staging December 13, 2022 23:37
@TurnerRiley TurnerRiley requested a review from a team December 13, 2022 23:38
@TurnerRiley TurnerRiley requested a review from a team December 14, 2022 22:15
Copy link
Contributor

@megcrenshaw megcrenshaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done working through this gnarly logic!

@TurnerRiley TurnerRiley merged commit 4a075cd into staging Dec 15, 2022
@TurnerRiley TurnerRiley deleted the show-workshop-exit-survey-for-yearlong-plc branch December 15, 2022 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants