Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Google Blockly] Changes to prep for v9 #49468

Merged
merged 5 commits into from
Dec 14, 2022

Conversation

mikeharv
Copy link
Contributor

@mikeharv mikeharv commented Dec 13, 2022

To simply the bump from Blockly v8 to v9, there are some changes that are part of the feature branch currently in review that can be merged ahead of time without breaking anything. This PR aims to do that, thereby reducing the complexity (and risk) of the actual version bump. For more context: #49311

Redoes changes from:

Links

Testing story

Deployment strategy

Follow-up work

Privacy

Security

Caching

PR Checklist:

  • Tests provide adequate coverage
  • Privacy and Security impacts have been assessed
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

@mikeharv mikeharv marked this pull request as ready for review December 13, 2022 16:59
@mikeharv mikeharv requested a review from a team December 13, 2022 17:00
@mikeharv mikeharv changed the title Mike/test fixes pre v9 blockly [Google Blockly] Changes to prep for v9 Dec 13, 2022
@mikeharv mikeharv mentioned this pull request Dec 13, 2022
8 tasks
Copy link
Contributor

@fisher-alice fisher-alice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice idea to lay the groundwork here for the upcoming version bump.

JSON.stringify(registry)
);
// Reset context menu for other tests.
GoogleBlockly.ContextMenuRegistry.registry.reset();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice clean up here.

@mikeharv mikeharv merged commit 4bc3fb9 into staging Dec 14, 2022
@mikeharv mikeharv deleted the mike/test-fixes-pre-v9-blockly branch December 14, 2022 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants