Add label and aria-expanded for Javalab file options toggle button #49473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apps/src/javalab/JavalabEditor.jsx
Outdated
| @@ -714,6 +714,7 @@ class JavalabEditor extends React.Component { | |||
| <span>{fileMetadata[tabKey]}</span> | |||
| {activeTabKey === tabKey && !isReadOnlyWorkspace && ( | |||
| <button | |||
| aria-label="File options" | |||
There was a problem hiding this comment.
nit: this string should be translatable
maddiedierker
approved these changes
Dec 13, 2022
rshipp
changed the title
rshipp
commented
Dec 14, 2022
apps/src/javalab/JavalabEditor.jsx
Outdated
| @@ -714,6 +714,8 @@ class JavalabEditor extends React.Component { | |||
| <span>{fileMetadata[tabKey]}</span> | |||
| {activeTabKey === tabKey && !isReadOnlyWorkspace && ( | |||
| <button | |||
| aria-label={i18n.fileOptions()} | |||
| aria-expanded={contextTarget === tabKey ? true : false} | |||
There was a problem hiding this comment.
(this logic is copied from ~10 lines below). i could also simplify it to contextTarget === tabKey, i'm not sure which is more readable.
There was a problem hiding this comment.
i think contextTarget === tabKey is more readable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a label to the file explorer button in Javalab. I used what looked like the simplest approach in this article on accessible icon buttons, and a label text that matches the behavior of the button. Let me know if you think I should change any of that!
Links