Add aria-label to progress bubble links #49476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The progress bubble
BubbleLinkcomponent already has ana11y_descriptionprop that's being exposed through atitleattribute in theatag. This works for some screenreaders (e.g. JAWS, NVDA), but not all of them (e.g. chrome screenreader extension). This PR adds the same text in anaria-labelattribute, to support those missing screenreaders. I tested with JAWS and NVDA, and confirmed it does not read the label twice when this change is in place.In this Javalab example (link in JIRA task), the descriptions look like "Level 2 Lesson Java Lab". They do not contain information about the completion status, so that information remains inaccessible since it's only represented by color. If we want to try adding that here too, I'm happy to do so.
Links