A11Y-7: Add alt text to careers page images #49513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
molly-moen
approved these changes
Dec 14, 2022
| @@ -7255,6 +7255,8 @@ | |||
|
|
|||
| language_label: "Language" | |||
|
|
|||
| careers_page_code_pride_alt_text: "Two female-presenting employees smile while holding the ends of a Code.org-branded rainbow banner. Behind them, several people are wearing Code.org shirts and waving rainbow flags while walking alongside a multi-colored Volkswagon bug." | |||
There was a problem hiding this comment.
typo: should be "Volkswagen"
megcrenshaw
reviewed
Dec 14, 2022
| @@ -7255,6 +7255,8 @@ | |||
|
|
|||
| language_label: "Language" | |||
|
|
|||
| careers_page_code_pride_alt_text: "Two female-presenting employees smile while holding the ends of a Code.org-branded rainbow banner. Behind them, several people are wearing Code.org shirts and waving rainbow flags while walking alongside a multi-colored Volkswagon bug." | |||
There was a problem hiding this comment.
I really like that you added this description!
Nit: I think female has a biological connotation that I don't think you're intending. Maybe feminine-presenting or woman-presenting? Language for gender is evolving which makes this hard!
hannahbergam
approved these changes
Dec 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds alt text for these two images. I decided to give the all-employee photo empty alt text because it doesn't feel like it conveys anything in particular, but the Code.org pride photo feels worth explaining.
Links
Jira ticket: https://codedotorg.atlassian.net/browse/A11Y-7
Testing story
Tested locally with VoiceOver (see output below).