Updating semantics of census buttons

[hannahbergam]

Real talk: how often do we use the census reviewer page? Seems worth auditing. It's also very very hard to repro locally.

CensusForm.jsx (only box shadow difference)
Before:

After:

I don't even want to talk about or admit HOW MANY HOURS it took me to create enough false data to actually see these forms. What matters? I got these screenshots and was able to verify that removing these lines doesn't change the buttons apart from the box shadows.

TableBefore:

TableAfter:

ReviewDetailsBefore:

ReviewDetailsAfter:

Links

• spec:
• jira ticket: https://codedotorg.atlassian.net/browse/A11Y-115
• https://codedotorg.atlassian.net/browse/A11Y-117
• https://codedotorg.atlassian.net/browse/A11Y-116

Testing story

Deployment strategy

Follow-up work

Privacy

Security

Caching

PR Checklist:

• Tests provide adequate coverage
• Privacy and Security impacts have been assessed
• Code is well-commented
• New features are translatable or updates will not break translations
• Relevant documentation has been added or updated
• User impact is well-understood and desirable
• Pull Request is labeled appropriately
• Follow-up work items (including potential tech debt) are tracked and linked

[bencodeorg]

Nice persistence getting this done!

Re: does anyone use this, just checked in production -- 6 records added to census_inaccuracy_investigations in 2022.

[hannahbergam]

Nice persistence getting this done!

Re: does anyone use this, just checked in production -- 6 records added to census_inaccuracy_investigations in 2022.

Ha! So sometimes people use this! Do we know who is in charge of reviewing them?