Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tab-navigation for ContentContainer links #49544

Merged
merged 2 commits into from
Jan 5, 2023
Merged

Fix tab-navigation for ContentContainer links #49544

merged 2 commits into from
Jan 5, 2023

Conversation

rshipp
Copy link
Contributor

@rshipp rshipp commented Dec 15, 2022

Moves the chevron inside the same link as the text, and renders it "inline-block" so it doesn't get underlined on hover.

LTR:
image

RTL:
image

Links

@rshipp rshipp requested a review from a team December 15, 2022 17:39
Copy link

@epeach epeach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! This definitely makes sense to have in one tag.

@rshipp rshipp merged commit d3750ea into staging Jan 5, 2023
@rshipp rshipp deleted the a11y-24 branch January 5, 2023 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants