Make input marker in debug console a <label> #49550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hannahbergam
approved these changes
Dec 15, 2022
bencodeorg
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes the ">" marking input in Applab/Gamelab's debug console a label for the input, which makes it auto-focus when clicked (this was the goal of a pre-existing onclick). Add an aria-label to the input itself, since the ">" label isn't helpful from a screenreader perspective.
Debug console in Applab (UI unaffected by this change)
Links
https://codedotorg.atlassian.net/browse/A11Y-164
Testing story
Tested clicking on ">" focuses input, and using a screen reader resulted in reading the aria label when visited via tab navigation.