Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Asset buttons and retry project save dialog buttons should not be clickable divs #49552

Merged
merged 2 commits into from
Dec 15, 2022
Merged

Asset buttons and retry project save dialog buttons should not be clickable divs #49552

merged 2 commits into from
Dec 15, 2022

Conversation

hannahbergam
Copy link
Contributor

@hannahbergam hannahbergam commented Dec 15, 2022 •
edited

This pr focuses on buttons in two places: the asset uploader row and the retry save dialog. The behavior on hover remains the same (the button turns white), but the buttons are now flat. Pics of before and after below:

Asset uploader row
Before:
Screen Shot 2022-12-15 at 12 36 01 PM

After:
Screen Shot 2022-12-15 at 12 36 56 PM

Also updates the save button
Before:
Screen Shot 2022-12-15 at 12 42 27 PM

After:
Screen Shot 2022-12-15 at 12 41 59 PM

Links

Testing story

Deployment strategy

Follow-up work

Privacy

Security

Caching

PR Checklist:

  • Tests provide adequate coverage
  • Privacy and Security impacts have been assessed
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

@hannahbergam hannahbergam changed the title Asset buttons should not be clickable divs Asset buttons and retry project save dialog buttons should not be clickable divs Dec 15, 2022
@hannahbergam hannahbergam requested a review from a team December 15, 2022 20:45
rshipp
rshipp approved these changes Dec 15, 2022
View reviewed changes
Copy link
Contributor

@rshipp rshipp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@hannahbergam hannahbergam merged commit d7a61e9 into staging Dec 15, 2022
@hannahbergam hannahbergam deleted the hbergam/more-semantics branch December 15, 2022 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rshipp rshipp rshipp approved these changes

Assignees
No one assigned
Labels
accessibility
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hannahbergam @rshipp