Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translates Stories to new storybook api #49627

Merged
merged 2 commits into from
Jan 5, 2023
Merged

Translates Stories to new storybook api #49627

merged 2 commits into from
Jan 5, 2023

Conversation

hannahbergam
Copy link
Contributor

@hannahbergam hannahbergam commented Jan 3, 2023

These are two great storybook applications because there's huge variety in UI displays. It's helpful to view them all at once!

The ProgressBubble uses a new concept for the storybook translation that attempts to mimic the functionality of .map() in the old api. I merged the stories at the end (outside of the map portion) into the same list so they could all be exported together. Happy to hear feedback if there are ideas on how else to approach this! It isn't quite as clean as some of the other storybook translations, but it's certainly more efficient than enumerating each possible variety. Thank you Emily for your problem solving genius!

Here's an example of one of them in the new storybook for ProgressLevelSet:

Screen Shot 2023-01-03 at 2 53 14 PM

Links

Testing story

Deployment strategy

Follow-up work

Privacy

Security

Caching

PR Checklist:

  • Tests provide adequate coverage
  • Privacy and Security impacts have been assessed
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

@hannahbergam hannahbergam changed the title Translates ProgressLevelSet to new storybook api Translates Stories to new storybook api Jan 4, 2023
@hannahbergam hannahbergam requested review from ebeastlake and a team January 4, 2023 21:21
@ebeastlake
Copy link
Contributor

LGTM but I'll leave 👍 to someone else since I was involved. Nice work, Hannah!

Copy link
Contributor

@bethanyaconnor bethanyaconnor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice solution!

@hannahbergam hannahbergam merged commit d57af44 into staging Jan 5, 2023
@hannahbergam hannahbergam deleted the hbergam/story branch January 5, 2023 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants