Music: refactor timeline component #49637
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A couple refactors to the
Timeline
component which will be useful for some upcoming work for adding a new tracks-based programming model. Refactors include migrating styles to SCSS where possible, convertingTimeline
to a functional component, and splitting out the timeline events into a separate component (TimelineSampleEvents
). This will allow us to easily switch between sample-based timeline elements and track-based timeline elements. This should not affect any current functionality.Links
Testing story
Deployment strategy
Follow-up work
Privacy
Security
Caching
PR Checklist: