Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Music: refactor timeline component #49637

Merged
merged 1 commit into from
Jan 5, 2023

Conversation

sanchitmalhotra126
Copy link
Contributor

A couple refactors to the Timeline component which will be useful for some upcoming work for adding a new tracks-based programming model. Refactors include migrating styles to SCSS where possible, converting Timeline to a functional component, and splitting out the timeline events into a separate component (TimelineSampleEvents). This will allow us to easily switch between sample-based timeline elements and track-based timeline elements. This should not affect any current functionality.

Links

Testing story

Deployment strategy

Follow-up work

Privacy

Security

Caching

PR Checklist:

  • Tests provide adequate coverage
  • Privacy and Security impacts have been assessed
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

@sanchitmalhotra126 sanchitmalhotra126 requested review from breville and a team January 4, 2023 19:46
Copy link
Member

@breville breville left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Also tested locally, and everything appears same as before!

@sanchitmalhotra126 sanchitmalhotra126 merged commit 9343063 into staging Jan 5, 2023
@sanchitmalhotra126 sanchitmalhotra126 deleted the sanchit/music/refactor-timeline branch January 5, 2023 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants