A11y 35 alt text circuit playground images #49641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgc1194
requested review from
epeach,
annaxuphoto,
hannahbergam and
megcrenshaw
hannahbergam
approved these changes
Jan 4, 2023
| @@ -361,6 +361,7 @@ | |||
| "makerSetupChromebookHistoricalNote": "Previously, we required the installation of the Code.org Serial Connector to use the Maker Toolkit with Chromebooks. This is no longer needed. If you have the Code.org Serial Connector installed, you may uninstall it if you wish. We will be removing it from the Chrome Web Store at the end of November. This will not affect your experience with the Maker Toolkit and requires no action from you.", | |||
| "makerSetupChromebookPage": "Open this page ([{makerSetupPage}]({makerSetupPage})) on your Chromebook.", | |||
| "makerSetupCircuitPlaygroundDescription": "The Adafruit [Circuit Playground Express](https://www.adafruit.com/product/3399) (and the older [Circuit Playground Classic](https://www.adafruit.com/product/3000)) is a programmable circuit board with built-in components that make getting started with physical computing quick and fun.\n\nIn the physical computing unit of [Computer Science Discoveries](https://code.org/educate/csd) students use the Circuit Playground tethered via USB to their computers to allow for online curriculum integration and interactive debugging of programs.\n\nPlease follow the instructions below to connect your board to Code.org.", | |||
| "makerSetupCircuitPlaygroundImageAltText": "The Circuit Playground board is a circular circuit board with a USB connector at the top rim, 14 connection pins along the rim, 10 LED lights, two buttons and multiple sensors.", | |||
There was a problem hiding this comment.
I think these are so great! Interested in feedback: I'm torn on whether the first part 'The circuit playground board' is necessary here. I wonder if the title header is enough context.
There was a problem hiding this comment.
I'm good with keeping it, but don't have a strong opinion either way!
There was a problem hiding this comment.
I do agree, I think either way would be arbitrary. I am going to keep it as is, as the images and Alt text could be used in other parts of the website with less context.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding alt text to the following images:
Links
Testing story
Testing links: http://localhost-studio.code.org:3000/maker/setup?enableExperiments=microbit
Used Screen Reader Chrome extension to test Alt text.
PR Checklist: