Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DTL (Test > Levelbuilder): c1b1171a #49648

Merged
merged 36 commits into from
Jan 5, 2023

Conversation

deploy-code-org
Copy link
Contributor

No description provided.

Hamms and others added 30 commits December 13, 2022 13:27
The monolithic Google API Client gem is deprecated, and has been split up into several separate gems with isolated functionality. Generic utility functionality has been centralized into the `google-apis-core` gem, and service-specific functionality has been put into various `google-apis-{service}_{version}` gems. Based on our current usage of the monolithic gem, we should only need three of these individual service gems.
Checks that arrays are sliced with endless ranges instead of `ary` on Ruby 2.6+.

Fix applied automatically with `bundle exec rubocop --auto-correct-all --only Style/SlicingWithRange`. I then manually examined each instance to confirm that the receivers are indeed Arrays

- https://www.rubydoc.info/gems/rubocop/RuboCop/Cop/Style/SlicingWithRange
- https://docs.rubocop.org/rubocop/cops_style.html#styleslicingwithrange
This will create metrics for the tests included here
Co-authored-by: Darin Webb <darin@code.org>
DTT (Staging > Test) [robo-dtt]
DTT (Staging > Test) [robo-dtt]
DTT (Staging > Test) [robo-dtt]
* Update zendesk_slack_report

* Fix alphabetization of a couple mappings

* A couple more updates
* Instrument login type picked for amplitude

* Use camelCase for property keys

* Add test that analyticsReporter is called when selecting a login card
* Fix instructions audio hover state

* Move styles to CSS

* Fix test
Fix Violations of and Reenable `Style/SlicingWithRange`
DTT (Staging > Test) [robo-dtt]
* fix not showing info bug

* begin cleanup of logic for readability and add test comments

* add basic unit tests

* update tests0

* finish adding tests

* fix isOffered and simplify courseWorkshops creation

* remove ref to at() command
DTT (Staging > Test) [robo-dtt]
* Add aria-label to animation cards

* Improve HTML semantics of PoemSelector form

* Add ariaLabel to Weblab fullscreen toggle button
deploy-code-org and others added 6 commits January 3, 2023 17:08
DTT (Staging > Test) [robo-dtt]
)

* Allow levelbuilders to overwrite existing animations

* Update text now that animations can be replaced

* /s/overwrite/replace
DTT (Staging > Test) [robo-dtt]
@deploy-code-org deploy-code-org requested review from a team as code owners January 5, 2023 09:20
@deploy-code-org deploy-code-org merged commit f6403f9 into levelbuilder Jan 5, 2023
@deploy-code-org deploy-code-org deleted the dtl_candidate_c1b1171a branch January 5, 2023 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants