-
Notifications
You must be signed in to change notification settings - Fork 481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DTL (Test > Levelbuilder): c1b1171a #49648
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The monolithic Google API Client gem is deprecated, and has been split up into several separate gems with isolated functionality. Generic utility functionality has been centralized into the `google-apis-core` gem, and service-specific functionality has been put into various `google-apis-{service}_{version}` gems. Based on our current usage of the monolithic gem, we should only need three of these individual service gems.
Checks that arrays are sliced with endless ranges instead of `ary` on Ruby 2.6+. Fix applied automatically with `bundle exec rubocop --auto-correct-all --only Style/SlicingWithRange`. I then manually examined each instance to confirm that the receivers are indeed Arrays - https://www.rubydoc.info/gems/rubocop/RuboCop/Cop/Style/SlicingWithRange - https://docs.rubocop.org/rubocop/cops_style.html#styleslicingwithrange
This will create metrics for the tests included here
Co-authored-by: Darin Webb <darin@code.org>
DTT (Staging > Test) [robo-dtt]
Rake metrics 2
DTT (Staging > Test) [robo-dtt]
Adding rake metrics seed
DTT (Staging > Test) [robo-dtt]
* Update zendesk_slack_report * Fix alphabetization of a couple mappings * A couple more updates
* Instrument login type picked for amplitude * Use camelCase for property keys * Add test that analyticsReporter is called when selecting a login card
* Fix instructions audio hover state * Move styles to CSS * Fix test
Fix Violations of and Reenable `Style/SlicingWithRange`
DTT (Staging > Test) [robo-dtt]
* fix not showing info bug * begin cleanup of logic for readability and add test comments * add basic unit tests * update tests0 * finish adding tests * fix isOffered and simplify courseWorkshops creation * remove ref to at() command
DTT (Staging > Test) [robo-dtt]
* Add aria-label to animation cards * Improve HTML semantics of PoemSelector form * Add ariaLabel to Weblab fullscreen toggle button
DTT (Staging > Test) [robo-dtt]
…t-gem Split up `google-api-client` Gem
DTT (Staging > Test) [robo-dtt]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.