Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Violations of and Reenable Lint/ScriptPermission #49660

Merged
merged 1 commit into from
Jan 5, 2023
Merged

Fix Violations of and Reenable Lint/ScriptPermission #49660

merged 1 commit into from
Jan 5, 2023

Conversation

Hamms
Copy link
Contributor

@Hamms Hamms commented Jan 5, 2023

Fix applied automatically with bundle exec rubocop --auto-correct-all --only Lint/ScriptPermission. Specifically, the fix grants execute permission to all files which start with a shebang directive.

Checks if a file which has a shebang line as its first line is granted execute permission.

Links

PR Checklist:

  • Tests provide adequate coverage
  • Privacy and Security impacts have been assessed
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

@Hamms
Fix Violations of and Reenable Lint/ScriptPermission
3a49dab 
Fix applied automatically with `bundle exec rubocop --auto-correct-all --only Lint/ScriptPermission`. Specifically, the fix grants execute permission to all files which start with a shebang directive.

> Checks if a file which has a shebang line as its first line is granted execute permission.

- https://www.rubydoc.info/gems/rubocop/RuboCop/Cop/Lint/ScriptPermission
@Hamms Hamms requested a review from a team as a code owner January 5, 2023 21:22
@Hamms Hamms requested a review from a team January 5, 2023 21:23
@Hamms Hamms merged commit 184662f into staging Jan 5, 2023
@Hamms Hamms deleted the fix-Lint/ScriptPermission branch January 5, 2023 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bethanyaconnor bethanyaconnor bethanyaconnor approved these changes

Assignees
No one assigned
Labels
code-hygiene
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Hamms @bethanyaconnor