Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SETUP.md #49758

Merged
merged 1 commit into from
Feb 9, 2023
Merged

Update SETUP.md #49758

merged 1 commit into from
Feb 9, 2023

Conversation

sanchitmalhotra126
Copy link
Contributor

Two quick updates to the setup guide based on a few issues I ran into doing a fresh setup on a new machine (M1 Macbook Pro).

Links

Testing story

Deployment strategy

Follow-up work

Privacy

Security

Caching

PR Checklist:

  • Tests provide adequate coverage
  • Privacy and Security impacts have been assessed
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

@sanchitmalhotra126 sanchitmalhotra126 requested a review from a team January 11, 2023 21:07
Copy link
Contributor

@Hamms Hamms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change makes sense to me, but it might be a good idea to also get a review from someone familiar with homebrew and other mac-specific details

@sureshc
Copy link
Contributor

sureshc commented Jan 18, 2023

This seems to be the standard solution for macOS since macOS 10.14. Wonder why it hasn’t popped up before. We have some other special configuration setup options for macOS related to openssl.

@sanchitmalhotra126 sanchitmalhotra126 merged commit ce677f2 into staging Feb 9, 2023
@sanchitmalhotra126 sanchitmalhotra126 deleted the sanchit/update-readme branch February 9, 2023 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants