prune family names from list in script constants

[davidsbailey]

Follow-up from https://github.com/code-dot-org/code-dot-org/pull/49755/files/d73237b9c14c3b4ea34a4ca57c56fc3999f6462a#r1069930260 . This list was misleading because it had some cruft in it, and the comment implied that new family names needed to be added to it. This PR removes the cruft and fixes the comment.

Testing story

• Manually verified that the result of CourseVersion.course_offering_keys('Unit').sort.join("\n") contains the removed family names:
  • on staging, the result contains aiml and all the CSF family names
  • on test, the result contains ui-test-versioned-script
• UI tests cover the removal of ui-test-versioned-script:

  code-dot-org/dashboard/test/ui/features/teacher_tools/course_versions.feature

  Lines 144 to 146 in 9cdbffe

  	Scenario: Unversioned script url redirects to latest script version
  	When I am on "http://studio.code.org/s/ui-test-versioned-script"
  	And I get redirected to "/s/ui-test-versioned-script-2019" via "dashboard"

• verified that the following redirects stills work
  • http://localhost-studio.code.org:3000/s/coursea
  • http://localhost-studio.code.org:3000/s/express
  • http://localhost-studio.code.org:3000/s/aiml

[megcrenshaw]

Great cleanup –– this is much clearer to me, who still gets confused about family names!

[megcrenshaw]

Looks like we reference these constants in two places, and Ruby constants always feel a bit magical to me :D.

To check my understanding: we import ScriptConstants in our Unit model, so other places can access the COURSEA constant via Unit::COURSEA. And that syntax stays consistent whether or not this constant is inside of an array (like FAMILY_NAMES) or not?

[davidsbailey]

Correct! To be slightly more specific we include ScriptConstants into the Unit class

[davidsbailey]

Including a module into a class makes all of the module's members accessible on the class.

[megcrenshaw]

Ah, include is different from import? So the "module's members" include all constants, regardless of how they're stored (or what kind of data structure they're stored in).

Anyways, I think I'm getting it –– thank you!

[davidsbailey]

yes, for modules require and include are different. this page describes what happens when you include a module: https://ruby-doc.org/core-2.6.3/Module.html

you can also require a module, in which case it behaves a lot like requiring a class, e.g.:

code-dot-org/aws/ci_build

Line 36 in 52c18b0

require 'cdo/metrics_helper'

there are many blog posts on the internet about this, the main thing I would suggest is that you search for "ruby" and not "rails" because this is actually plan ruby stuff not specific to rails.

[megcrenshaw]

Thank you for doing this!

[bethanyaconnor]

Thanks for doing this!