-
Notifications
You must be signed in to change notification settings - Fork 479
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Install Ruby with ruby-build
in Chef
#49864
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hamms
added
the
Ruby Update
Everything related to work to update the version of Ruby our codebase runs on
label
Jan 18, 2023
…on' functionality
Also add an overwrite option to the tarball extraction; otherwise, trying to update to a newer version of ruby-build on an existing server which already has /tmp/ data will fail
cat5inthecradle
approved these changes
Feb 10, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just based on some recent issues, I want to call out that we need to make sure AMI Builider is behaving properly after the change.
This was referenced Mar 2, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specifically, stop using the Brightbox PPA installation method in preparation for an eventual update to Ruby 3.0, which is not provided by those PPAs. Also, break up the existing monolithic
cdo-ruby::default
recipe into several smaller recipes referenced from the default recipe.I chose
ruby-build
for a couple of reasons. It's a component ofrbenv
(which is the method we recommend developers use, and which we use for our CI builds) provided as a standalone tool. Because our frontend servers don't need to manage multiple versions of Ruby at once, they don't need the full functionality provided byrbenv
, but by using a piece of it we make all our environments a little bit more similar to one another. It is also one of the installation methods recommended by official ruby docs.Links
Testing story
Deployment strategy
We'll want to carefully monitor our existing persistent managed servers as this change gets applied to ensure that it does so successfully; although with an adhoc it's possible to test the basic principle of this change being applied to an existing server, in reality our existing servers have had enough one-off changes applied to them over the years that there's always the change for some inconsistency or incompatibility.
PR Checklist: