Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Music Lab: set tracks mode to default #50080

Merged
merged 1 commit into from
Feb 6, 2023

Conversation

sanchitmalhotra126
Copy link
Contributor

Sets "Tracks" mode to default in Music Lab. I refactored some of the code around accessing the block mode in order to support an easily configurable default mode. Also adds the label "and" before new extra samples on the play block.

Links

Testing story

Deployment strategy

Follow-up work

Privacy

Security

Caching

PR Checklist:

  • Tests provide adequate coverage
  • Privacy and Security impacts have been assessed
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

@sanchitmalhotra126 sanchitmalhotra126 requested review from breville and a team February 3, 2023 23:20
@sanchitmalhotra126 sanchitmalhotra126 merged commit 26fc785 into staging Feb 6, 2023
@sanchitmalhotra126 sanchitmalhotra126 deleted the sanchit/music/default-tracks branch February 6, 2023 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants