[Amplitude] Send Record on Teacher Login #50081
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ) { | ||
| trySetLocalStorage(LOGGED_TEACHER_SESSION, 'true'); | ||
|
|
||
| analyticsReporter.sendEvent(EVENTS.TEACHER_LOGIN_EVENT, { |
There was a problem hiding this comment.
Forgive my ignorance on local storage -- would this trigger correctly if a teacher logged in, logged out, and logged in again?
There was a problem hiding this comment.
Good catch! I meant for this to be trySetSESSIONStorage - fixing!
| @@ -57,6 +60,13 @@ describe('StudentHomepage', () => { | |||
| }); | |||
| }); | |||
|
|
|||
| it('does not log an Amplitude event for teacher signing-in', () => { | |||
There was a problem hiding this comment.
nit: should this test name be "does not log an Amplitude event for student signing-in"?
bethanyaconnor
approved these changes
Feb 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of our Amplitude project.
Triggers when a teacher renders the homepage, but only once per session (to emulate the 'on login' experience).
Includes testing.