New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove grades_teaching question from Admin/Counselor workshop enrollment form #50105

Merged

TurnerRiley merged 1 commit into staging from remove-grades-teaching-question-from-admin-counselor-enroll

Feb 7, 2023

Contributor

TurnerRiley commented Feb 6, 2023

This PR remove the grades_teaching question from just the Admin/Counselor workshop enrollment form (not other forms that also use the question).

Previously showed the grades_teaching question in the Admin/Counselor workshop enrollment form

Now does not show the grades_teaching question in the Admin/Counselor workshop enrollment form

Still shows the grades_teaching question in other forms that use it

Links

Jira ticket: here

Testing story

Local testing and updating unit tests.

PR Checklist:

Tests provide adequate coverage
Privacy and Security impacts have been assessed
Code is well-commented
New features are translatable or updates will not break translations
Relevant documentation has been added or updated
User impact is well-understood and desirable
Pull Request is labeled appropriately
Follow-up work items (including potential tech debt) are tracked and linked


          remove question and update apps tests

fc888c1

TurnerRiley requested a review from a team

February 7, 2023 17:06

megcrenshaw approved these changes

View reviewed changes

TurnerRiley merged commit 7fcc424 into staging

TurnerRiley deleted the remove-grades-teaching-question-from-admin-counselor-enroll branch

February 7, 2023 17:19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment