Translating storybook stories to new API #50127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hannahbergam
commented
Feb 8, 2023
| component: Dialog | ||
| }; | ||
|
|
||
| /* |
There was a problem hiding this comment.
I tried to preserve the instructions in a comment, so that a developer would still be able to read them!
hannahbergam
commented
Feb 8, 2023
| /> | ||
| ); | ||
|
|
||
| export const NoFooter = () => ( |
There was a problem hiding this comment.
Though I didn't add the descriptions when all the messaging comes through with a descriptive name:)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR translates three storybook files of shared components to the new API, including Dialog and BaseDialog!
QuickActionsCell - I added a div with a styling so that you can actually see the popup when you click to view the options. Example here:
BaseDialog has several different potential views. This makes for a great storybook! Here is one example (after clicking to open):
And finally, the Dialog component. This one was fun- there are so many great examples are they're all quite different! Here is the full width one:
Links
Testing story
Deployment strategy
Follow-up work
Privacy
Security
Caching
PR Checklist: