[Amplitude] Section Sign In - Dismiss or Accept #50131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hannahbergam
approved these changes
Feb 7, 2023
| @@ -2,6 +2,8 @@ const EVENTS = { | |||
| // Sign-up flow | |||
| ACCOUNT_TYPE_PICKED_EVENT: 'Account Type Picked', | |||
| SIGN_UP_FINISHED_EVENT: 'Sign Up Finished', | |||
| SECTION_SETUP_SIGN_IN_EVENT: 'Section Setup Sign In', | |||
| ABANDON_SECTION_SETUP_SIGN_IN_EVENT: 'Abandon Section Setup Sign In', | |||
There was a problem hiding this comment.
Would it be possible to align between 'abandon' and 'dismiss' throughout this implementation (I think it would be ideal if the event names/testing/function names matched)? I think either is good:)
| render() { | ||
| const {isOpen} = this.state; | ||
|
|
||
| return ( | ||
| <BaseDialog | ||
| useUpdatedStyles | ||
| handleClose={() => this.setState({isOpen: false})} | ||
| handleClose={this.abandonEditingSection} |
There was a problem hiding this comment.
love the abstraction here:)
| analyticsSpy.restore(); | ||
| }); | ||
|
|
||
| it('logs an Amplitude event for when the user selects to create a section', () => { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an Amplitude log call for both the "Accept" (Start to create a section) and "Dismiss" (no action) options on the Section Creation Interstitial Dialog.
Includes test.