Removing useDeprecatedTag from unit calendar button #50163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgc1194
reviewed
Feb 9, 2023
| @@ -64,3 +64,10 @@ export default class UnitCalendarButton extends React.Component { | |||
| ); | |||
| } | |||
| } | |||
|
|
|||
| const styles = { | |||
There was a problem hiding this comment.
Just wonder if the size of the button adapts with changes in the length of the text. Thinking about translations.
There was a problem hiding this comment.
Yep- just edited the text so you can see what it looks like!
mgc1194
approved these changes
Feb 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the button tab navigable, and adds styling to maintain consistency with the neighboring buttons!
Before:
After:
Links
Testing story
Deployment strategy
Follow-up work
Privacy
Security
Caching
PR Checklist: