Remove question from Amazon Future Engineers form

[megcrenshaw]

Removes the AWS Educate checkbox on the Amazon Future Engineers form. In development:

In prod, it's the last checkbox before the required privacy policy checkbox:

Links

Testing story

Tested this manually:

• Seeded schools:
  • bundle exec rake seed:schools
• Added school info to my account:
  • UserSchoolInfo.create!(user_id: user.id, school_info_id: SchoolInfo.last.id, start_date: Time.now, last_confirmation_date: Time.now)
• Changed prop schoolEligible to hardcode to true in amazon_future_engineer_eligibility.js
• Navigated to http://localhost.code.org:3000/afe, filled out form, submitted successfully:

Deployment strategy

Follow-up work

Privacy

Security

Caching

PR Checklist:

• Tests provide adequate coverage
• Privacy and Security impacts have been assessed
• Code is well-commented
• New features are translatable or updates will not break translations
• Relevant documentation has been added or updated
• User impact is well-understood and desirable
• Pull Request is labeled appropriately
• Follow-up work items (including potential tech debt) are tracked and linked

[davidsbailey]

it looks like this data gets posted to pardot.com. are you able to verify that pardot can handle this field being removed? it might be necessary to sign in to pardot and see what we have configured there.

[megcrenshaw]

Ah, I see. Yes, I wasn't able to get to the "Congratulations" that I screenshotted when I tried to "break" the form, but I agree that I didn't actually check what gets sent to Pardot. I'll look into this –– thanks!

[davidsbailey]

• Navigated to http://localhost.code.org:3000/afe, filled out form, submitted successfully:

I'm a bit skeptical of this verification step because we bail here if CDO.afe_pardot_form_handler_url is not defined:

code-dot-org/dashboard/lib/services/afe_enrollment.rb

Line 56 in 9570243

return submission_body unless CDO.afe_pardot_form_handler_url

CDO.afe_pardot_form_handler_url is defined in prod, but not anywhere else:

• code-dot-org/config/production.yml.erb

  Line 35 in a22d066

  afe_pardot_form_handler_url: !Secret

• code-dot-org/config.yml.erb

  Line 249 in a22d066

  afe_pardot_form_handler_url:

so, I'm afraid this suggests we haven't really verified what will happen when this reaches prod (where the data will get sent to pardot).

[megcrenshaw]

Since AFE has their own Pardot URL that we use in our form submission, I did the following to validate this –– a bit janky, but I'm feeling confident that it worked

1. Retrieved the AWS Secret and hard-coded it in my config.yml.erb file:

afe_pardot_form_handler_url: https://go.pardot.com/l/**/*

2. In afe_enrollment.rb we return submission body if we do and do not have the URL

   code-dot-org/dashboard/lib/services/afe_enrollment.rb

   Lines 56 to 67 in 3e41701

   	return submission_body unless CDO.afe_pardot_form_handler_url
   	raise Error.new('AFE submission skipped: Terms and conditions were not accepted') unless amazon_terms
   	response = Net::HTTP.post_form(
   	URI(CDO.afe_pardot_form_handler_url),
   	submission_body
   	)
   	raise Error.new("AFE submission failed with HTTP #{response.code}") unless response.code == '200'
   	raise Error.new("AFE submission failed with a validation error") if /Cannot find error page/.match?(response.body)
   	submission_body

   So, I added some puts to see what response we got. After submitting the form, I get a 200 response code, and the response body does not contain Cannot find error page. Plus, I got emails from AFE (I put in my actual code.org email to check) verifying I'm now an "Amazon Future Engineer."

[davidsbailey]

nice job verifying! receiving the email from AFE seems to seal the deal.

Friendly reminder to please remove afe_pardot_form_handler_url from your locals before you forget :-)