Pulls in PL Course Offerings to new table, updates styling, tests #50664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hannahbergam
changed the title
| @@ -68,7 +68,7 @@ export default function CurriculumQuickAssignTopRow({ | |||
| <Button | |||
| id={'uitest-hoc-button'} | |||
| className={moduleStyles.buttonStyle} | |||
| text={i18n.courseOfferingHOC()} | |||
| text={i18n.teacherCourseHoc()} | |||
There was a problem hiding this comment.
When did this string change?
There was a problem hiding this comment.
HA I think I just realized that I was in the UK version of english which has this string as "The Hour of Code" (en_gb). Looks like I didn't need to change it (but now find it weird to have duplicate "Hour of Code" strings)
bethanyaconnor
approved these changes
Mar 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the PL functionality by querying the url param for participant type.
It also updates the styling of the labels so that the course offerings are left aligned and there is a right margin to keep appropriate space on the right edge of the table.
Links
Testing story
I added tests to the hocPl component to verify that the table renders as expected.
I will plan to add more tests for this area once I do the followup work to ensure only users with a facilitator permission can see this table
Deployment strategy
Follow-up work
Privacy
Security
Caching
PR Checklist: