rename one WorkshopEnrollment to WorkshopEnroll #50747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
megcrenshaw
approved these changes
Mar 15, 2023
|
Wonder: Could the first one be called WorkshopEnrollmentList to help make clear its the list of enrolled people and the second one be called WorkshopEnrollmentForm to make it clear its the form. I see you already merged this so no worries if we don't want to do it now. Just a thought |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today there are two react components named
WorkshopEnrollment:view / edit workshop page
page to actually enroll in a workshop
This makes it unnecessarily difficult to navigate the codebase. This PR helps resolve the ambiguity by renaming (2) to
WorkshopEnroll. This was easy to change so I am open to other names too.Testing story
There is no existing test coverage so I tested this manually. UI tests which require enrollment skip this step to save time, which is generally the right strategy except that there should still be one UI test covering the skipped step. adding a follow-up to add UI test coverage here: https://codedotorg.atlassian.net/browse/ACQ-481