Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

restoring deleted projectbeats code docs files and allowing new filenames to seed #50764

Merged
merged 1 commit into from
Mar 15, 2023

Conversation

hannahbergam
Copy link
Contributor

@hannahbergam hannahbergam commented Mar 14, 2023

This Pr fixes a seeding bug for programming_expressions. Nine new programming expressions docs were spontaneously deleted. This was not a user error, nor was it an issue with the cyclical nature of our deploy (the rest of the content scoop and deploy to production succeeded without a hitch).

Before, the seed_all function called to look for any new files in these specific folder names: {applab,gamelab,weblab,spritelab}. This meant that new environments were not pulled in (projectbeats being one of them). Now, the programming expression matches the patterns that existed already in programming_class and programming_environment.

Once I updated this and started adding back in the json files, the seeding worked locally! See below:
Screenshot 2023-03-14 at 3 28 59 PM

This list of folders seemed very intentional at the time- see PR here. Requesting review from Dani to see if this specificity is still necessary. A more conservative approach would be to add javalab and projectbeats to this list. However, I imagine we'd then run into the same issue again.

Investigation notes doc and slack threads here:
https://docs.google.com/document/d/1EV_1_X5RP8kQi2A8HT-duiHR6iiCyuE9mQ_GcHOCxeQ/edit
https://codedotorg.slack.com/archives/C0T0PNTM3/p1678478257127849

Links

Testing story

Deployment strategy

Follow-up work

Privacy

Security

Caching

PR Checklist:

  • Tests provide adequate coverage
  • Privacy and Security impacts have been assessed
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

@hannahbergam hannahbergam requested review from a team and dmcavoy March 14, 2023 22:34
Copy link
Contributor

@dmcavoy dmcavoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating this Hannah. I don't see any issue with this from my memory of this space.

@hannahbergam hannahbergam merged commit 2532122 into staging Mar 15, 2023
@hannahbergam hannahbergam deleted the hbergam/lb-codedocs-restore branch March 15, 2023 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants