restoring deleted projectbeats code docs files and allowing new filenames to seed #50764
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pr fixes a seeding bug for programming_expressions. Nine new programming expressions docs were spontaneously deleted. This was not a user error, nor was it an issue with the cyclical nature of our deploy (the rest of the content scoop and deploy to production succeeded without a hitch).
Before, the seed_all function called to look for any new files in these specific folder names: {applab,gamelab,weblab,spritelab}. This meant that new environments were not pulled in (projectbeats being one of them). Now, the programming expression matches the patterns that existed already in programming_class and programming_environment.
Once I updated this and started adding back in the json files, the seeding worked locally! See below:
This list of folders seemed very intentional at the time- see PR here. Requesting review from Dani to see if this specificity is still necessary. A more conservative approach would be to add javalab and projectbeats to this list. However, I imagine we'd then run into the same issue again.
Investigation notes doc and slack threads here:
https://docs.google.com/document/d/1EV_1_X5RP8kQi2A8HT-duiHR6iiCyuE9mQ_GcHOCxeQ/edit
https://codedotorg.slack.com/archives/C0T0PNTM3/p1678478257127849
Links
Testing story
Deployment strategy
Follow-up work
Privacy
Security
Caching
PR Checklist: