Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Unused petit Gem Dependency #50854

Merged
merged 1 commit into from
Mar 22, 2023
Merged

Remove Unused petit Gem Dependency #50854

merged 1 commit into from
Mar 22, 2023

Conversation

Hamms
Copy link
Contributor

@Hamms Hamms commented Mar 20, 2023

Originally added in #17132 to enable us to build a url-shortening service. As far as I can tell, we never got around to building that service and currently don't have any functionality we provide which uses this gem. Removing it in preparation for entirely removing our dependency on unicorn, which this gem is entangled with.

Links

Testing story

Searched slack, github, and the repository itself for any other references to this gem or the functionality we intended to build on top of it. Found nothing

Follow-up work

We could consider eliminating our fork at https://github.com/code-dot-org/petit

PR Checklist:

  • Tests provide adequate coverage
  • Privacy and Security impacts have been assessed
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

Originally added in #17132 to enable us to build a url-shortening service. As far as I can tell, we never got around to building that service and currently don't have any functionality we provide which uses this gem. Removing it in preparation for entirely removing our dependency on `unicorn`, which this gem is entangled with.
@Hamms Hamms marked this pull request as ready for review March 21, 2023 20:53
@Hamms Hamms requested a review from a team March 21, 2023 20:54
@Hamms Hamms merged commit 24b1f7f into staging Mar 22, 2023
@Hamms Hamms deleted the remove-petit branch March 22, 2023 19:11
@Hamms Hamms added the Ruby Update Everything related to work to update the version of Ruby our codebase runs on label Mar 22, 2023
@Hamms Hamms mentioned this pull request Apr 10, 2023
@Hamms Hamms mentioned this pull request Jun 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ruby Update Everything related to work to update the version of Ruby our codebase runs on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants