Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a Few More Using the last argument as keyword parameters is deprecated Warnings #50999

Merged
merged 1 commit into from
Apr 10, 2023

Conversation

Hamms
Copy link
Contributor

@Hamms Hamms commented Mar 29, 2023

In preparation for an update to Ruby 3.x; see #49447 for more context.

@Hamms Hamms added the Ruby Update Everything related to work to update the version of Ruby our codebase runs on label Mar 29, 2023
@Hamms Hamms marked this pull request as ready for review March 29, 2023 17:10
@Hamms Hamms requested a review from a team March 29, 2023 17:11
Copy link
Contributor

@sureshc sureshc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it bad that I wrote most of the method calls that are being updated here? 😬

@Hamms
Copy link
Contributor Author

Hamms commented Apr 10, 2023

Lol, nah; my understanding is that this invocation pattern is being deprecated because of how difficult it was for the Ruby team to continue to support the syntax in a consistent way, not because there was any problem with developers using it.

See Why we’re deprecating the automatic conversion from the documentation linked in the linked PR for more context

@Hamms Hamms merged commit 87af491 into staging Apr 10, 2023
@Hamms Hamms deleted the fix-more-last-argument-as-keyword-param-deprecations branch April 10, 2023 21:31
@Hamms Hamms mentioned this pull request Jun 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ruby Update Everything related to work to update the version of Ruby our codebase runs on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants