Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing teacherViewingStudentWork is undefined in topinstructions component #51118

Merged
merged 2 commits into from
Apr 6, 2023
Merged

Fixing teacherViewingStudentWork is undefined in topinstructions component #51118

merged 2 commits into from
Apr 6, 2023

Conversation

vijayamanohararaj
Copy link
Contributor

@vijayamanohararaj vijayamanohararaj commented Apr 4, 2023 •
edited

All our drone builds hit this issue resulting in noise when trying to root cause build failures for daily deployments.

JIRA ticket: https://codedotorg.atlassian.net/browse/TEACH-388?atlOrigin=eyJpIjoiMzkxMGJhOWNkMGU1NGMyY2JhODBjZDdjNDEzYmQ4OWUiLCJwIjoiamlyYS1zbGFjay1pbnQifQ

Testing story

Outside of unit tests, manually sanity tested scenarios around viewing course page as teacher

PR Checklist:

  • Tests provide adequate coverage
  • Privacy and Security impacts have been assessed
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

@vijayamanohararaj vijayamanohararaj force-pushed the vijaya/top_instructions_undefined branch from 9a12e60 to 2cf25b4 Compare April 6, 2023 03:35
@vijayamanohararaj vijayamanohararaj marked this pull request as ready for review April 6, 2023 15:45
@vijayamanohararaj vijayamanohararaj requested a review from a team April 6, 2023 15:46
bethanyaconnor
bethanyaconnor approved these changes Apr 6, 2023
View reviewed changes
Copy link
Contributor

@bethanyaconnor bethanyaconnor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing!

@vijayamanohararaj vijayamanohararaj merged commit 76110d5 into staging Apr 6, 2023
@vijayamanohararaj vijayamanohararaj deleted the vijaya/top_instructions_undefined branch April 6, 2023 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bethanyaconnor bethanyaconnor bethanyaconnor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vijayamanohararaj @bethanyaconnor