Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add share feedback banner to CFU summary page #51129

Merged
merged 5 commits into from
Apr 6, 2023
Merged

Add share feedback banner to CFU summary page #51129

merged 5 commits into from
Apr 6, 2023

Conversation

dju90
Copy link
Contributor

@dju90 dju90 commented Apr 5, 2023 •
edited

Links

Testing story

Tested locally
image

Follow-up work

  • Once FontAwesome is updated, update the banner icon to text bubbles as seen in the Figma mocks

PR Checklist:

  • Tests provide adequate coverage
  • Privacy and Security impacts have been assessed
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

@dju90 dju90 marked this pull request as ready for review April 6, 2023 06:19
@dju90 dju90 requested a review from a team as a code owner April 6, 2023 06:19
@dju90 dju90 requested a review from rshipp April 6, 2023 06:19
@dju90 dju90 requested a review from a team April 6, 2023 14:47
@dju90 dju90 merged commit fe1936d into staging Apr 6, 2023
@dju90 dju90 deleted the dju90/cfu-feedback-banner branch April 6, 2023 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rshipp rshipp rshipp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dju90 @rshipp