Fix Violations of and Reenable Style/HashAsLastArrayItem
#51498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
> Checks for presence or absence of braces around hash literal as a last array item depending on configuration. This feels particularly relevant as we prepare for an update to Ruby 3.0, in which [implicit hashes as the last argument of a method call was deprecated.](https://www.ruby-lang.org/en/news/2019/12/12/separation-of-positional-and-keyword-arguments-in-ruby-3-0/) Fix applied automatically with `bundle exec rubocop --auto-correct-all --only Style/HashAsLastArrayItem` - https://docs.rubocop.org/rubocop/cops_style.html#stylehashaslastarrayitem - https://www.rubydoc.info/gems/rubocop/RuboCop/Cop/Style/HashAsLastArrayItem
Hamms
added
code-hygiene
Ruby Update
bethanyaconnor
approved these changes
Apr 25, 2023
cat5inthecradle
approved these changes
Apr 25, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feels particularly relevant as we prepare for an update to Ruby 3.0, in which implicit hashes as the last argument of a method call was deprecated.
Fix applied automatically with
bundle exec rubocop --auto-correct-all --only Style/HashAsLastArrayItemLinks