Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Self-paced PL page post-launch updates #51945

Merged
merged 2 commits into from
May 18, 2023
Merged

Conversation

kelbyhawn
Copy link
Contributor

Fixing a couple things post-launch on https://code.org/educate/professional-development-online:

  • The duration of "Teaching Computer Science Principles" should be 3 hours. It is listed as 35 hours.
  • On mobile landscape the hero banner image was overflowing creating a scroll

Jira ticket: ACQ-599?


Before

Screenshot 2023-05-17 at 10 30 15 AM

After

Screenshot 2023-05-17 at 10 30 05 AM

Before

Before.mov

After

After.mov

@kelbyhawn kelbyhawn requested a review from dmcavoy May 17, 2023 20:21
@kelbyhawn kelbyhawn merged commit 7844718 into staging May 18, 2023
2 checks passed
@kelbyhawn kelbyhawn deleted the self-paced-pl-page-updates branch May 18, 2023 15:11
pablo-code-org pushed a commit that referenced this pull request May 25, 2023
* update csp duration to 3 hrs

* fix banner overflow issue
snickell pushed a commit that referenced this pull request Feb 3, 2024
* update csp duration to 3 hrs

* fix banner overflow issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants