Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace old script markdown with updated names #51946

Merged
merged 1 commit into from
May 18, 2023

Conversation

hannahbergam
Copy link
Contributor

@hannahbergam hannahbergam commented May 17, 2023

Issue:
CSD resources were cloned when they were still in a broken state (i.e. csd3/2023 instead of csd/2023).

Approach:
A find and replace of all resources with the markdown 'csd1/2023', 'csd2/2023', etc. -> 'csd/2023'.

Future work:
These resources still might not be pointing to the correct unit. For example, we might want to make sure the resource in the focus-on-coding4a-2023 unit actually points to a resource from focus-on-coding4a/2023. However, because we're not sure those resources exist in those places (and are sure they exist in csd), we elected to point to the correct CSD location instead of doing the larger work of finding the perfect name and copying over the resources.

Example:
Here is one of the resources that was copied, before and after the fix.

Before:
Screenshot 2023-05-17 at 10 15 13 AM

After:
Screenshot 2023-05-17 at 10 15 17 AM

Links

Testing story

Deployment strategy

Follow-up work

Privacy

Security

Caching

PR Checklist:

  • Tests provide adequate coverage
  • Privacy and Security impacts have been assessed
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

@hannahbergam hannahbergam requested a review from a team May 17, 2023 17:51
Copy link
Contributor

@bethanyaconnor bethanyaconnor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wooo! Can you make a ticket addressing the fact that these point to the wrong course version sometimes? I still don't know if that's worth fixing but I still want to think about it :)

@tess323
Copy link

tess323 commented May 17, 2023

😍

@hannahbergam
Copy link
Contributor Author

Wooo! Can you make a ticket addressing the fact that these point to the wrong course version sometimes? I still don't know if that's worth fixing but I still want to think about it :)

Added this to 'Candidates for Up Next'! https://codedotorg.atlassian.net/browse/TEACH-508

@hannahbergam hannahbergam merged commit 2f39e17 into staging May 18, 2023
2 checks passed
@hannahbergam hannahbergam deleted the hbergam/csd-resources-another-fix branch May 18, 2023 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants