Use String.prototype.charAt instead of .at #51955
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fisher-alice
approved these changes
May 17, 2023
Hamms
approved these changes
May 17, 2023
rshipp
changed the title
pablo-code-org
pushed a commit
that referenced
this pull request
May 25, 2023
snickell
pushed a commit
that referenced
this pull request
Feb 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the older
String.prototype.charAtin place of the newerString.prototype.at, to try to allow the build to pass.Links
Slack: https://codedotorg.slack.com/archives/C0T0PNTM3/p1684359034466229
Testing story
Ran the MultiResponses unit tests locally, but that won't prove this passes in the real build. Neither will running them in drone, since that passed with the
.atmethod originally.