Rename poetry.rb functions

[fisher-alice]

This PR renames two functions within poetry.rb:

• from poems_for_subtype to poem_list_for_standalone_app
• from poem_keys_for subtype to poem_list_keys_for_standalone_app.

Poetry has 3 subtypes: 'poetry', 'poetry_hoc', and 'time_capsule'. However, in poetry.rb, subtype is referred to as standalone_app.
The two functions mentioned above are renamed to clarify their purpose and maintain more consistency in naming.
This is a follow-up to this PR.

Links

• jira ticket
• Slack discussion

Testing story

I tested locally by opening new 'poetry', 'time_capsule', and 'poetry_hoc' projects and confirming there were no changes to the poem lists. I also viewed poem lists in the Poetry HOC levels.

Deployment strategy

Follow-up work

Privacy

Security

Caching

PR Checklist:

• Tests provide adequate coverage
• Privacy and Security impacts have been assessed
• Code is well-commented
• New features are translatable or updates will not break translations
• Relevant documentation has been added or updated
• User impact is well-understood and desirable
• Pull Request is labeled appropriately
• Follow-up work items (including potential tech debt) are tracked and linked

[mikeharv]

The changes here look good, especially after chatting through with Alice offline.
The term standalone_app initially threw me off because I was expecting that to refer to "bigger" apps like spritelab vs applab. Seeing that we only use this term in the context of SpriteLab/Poetry has feeling good that we're not overloading the term to mean different things in different context.

@molly-moen, I'm thinking you chose this label when we first looked into subtypes, so I know I've seen it a bunch already. Could you remind me how you interpret the term "standalone app"?

[molly-moen]

@molly-moen, I'm thinking you chose this label when we first looked into subtypes, so I know I've seen it a bunch already. Could you remind me how you interpret the term "standalone app"?

@mikeharv I interpret "standalone app" as the configuration for a project that can be run via a /projects/<standalone-app-name>/<channel-id> url. It is actually a term used on the frontend as well, and is defined as such. With some refactoring for the new projects client I ended up adding a new term for this, which is project_type. I am now wondering if I should change that to standalone_app_name to be consistent everywhere. project_type is a bit of a clearer term IMO, but it is new so going with consistency is probably better.

[mikeharv]

@molly-moen Thanks for explaining!
So it seems like the "standalone app" could be any thing from AppLab to Time Capsule and there's no real hierarchy of labs/subtypes present. I was thinking that the standalone app for things like Time Capsule and Story would be Poetry and Sprite Lab respectively. It's helpful to think about the app name mapping evenly to the project types we support.

project_type is a bit of a clearer term IMO, but it is new so going with consistency is probably better.

Agreed on both points!

[molly-moen]

nit: I think it would be a bit cleaner to name these poem_keys_for_standalone_app and poems_for_standalone_app, because a plural implies a list.

[fisher-alice]

Sure - sounds good. Will update

[fisher-alice]

And just to clarify, did you mean poems_keys_for_standalone_app or poem_keys_for_standalone_app?

[molly-moen]

poem_keys, because the list is of keys

[molly-moen]

LGTM, one naming nit but it's a matter of preference :)