Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strip level name before looking for a level in DslDefined.setup #51969

Merged
merged 1 commit into from
May 19, 2023

Conversation

bethanyaconnor
Copy link
Contributor

@bethanyaconnor bethanyaconnor commented May 18, 2023

Follow up to #51968. As whitespace is trimmed from the name when a level is saved, also trim that whitespace when looking for a level by name. I tested this with the issues that happened this morning and this would've prevented them. See the description of #51968 for more details.

There's likely to be other places we could fix but I didn't think it was worth the time to look for them.

@bethanyaconnor bethanyaconnor marked this pull request as ready for review May 18, 2023 18:53
@bethanyaconnor bethanyaconnor requested a review from a team May 18, 2023 18:54
Copy link
Contributor

@rshipp rshipp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! makes sense to me

@bethanyaconnor bethanyaconnor merged commit 4028181 into staging May 19, 2023
2 checks passed
@bethanyaconnor bethanyaconnor deleted the bethany/strip-name-before-dsl-setup branch May 19, 2023 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants