Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin Version of google-chrome-stable Package #51975

Merged
merged 2 commits into from
May 22, 2023

Conversation

Hamms
Copy link
Contributor

@Hamms Hamms commented May 18, 2023

Right now, we have a couple different versions of this package installed across our servers. Checking with apt-cache policy google-chrome-stable reveals:

staging:
google-chrome-stable:
  Installed: 103.0.5060.53-1
  Candidate: 113.0.5672.126-1
  Version table:
     113.0.5672.126-1 500
        500 http://dl.google.com/linux/chrome/deb stable/main amd64 Packages
 *** 103.0.5060.53-1 100
        100 /var/lib/dpkg/status

test:
google-chrome-stable:
  Installed: 77.0.3865.90-1
  Candidate: 103.0.5060.53-1
  Version table:
     103.0.5060.53-1 500
        500 http://dl.google.com/linux/chrome/deb stable/main amd64 Packages
 *** 77.0.3865.90-1 100
        100 /var/lib/dpkg/status

The discrepancy between staging and test specifically is causing some problems; some apps code using newer browser features fails to build on test but passes on staging, which can lead to confusingly delayed DTT failures when staging builds the apps package at first and test only attempts to build some time after the offending PR has been merged.

To resolve, we explicitly specify which version we should target. I've chosen to target the version currently installed on staging because it's closest to the version we target for our UI tests, but we could alternatively choose to update to version 113.

Links

See threads at https://codedotorg.slack.com/archives/C0T0PNR0D/p1683573120446859 and https://codedotorg.slack.com/archives/C0T0PNTM3/p1684359034466229and for more context.

Testing story

Verified on an adhoc that we correctly install the targeted version.

…ed so that all our servers install the same one
@Hamms Hamms changed the title Specify the version of the google-chrome-stable package to be install… Pin Version of google-chrome-stable Package May 18, 2023
@Hamms Hamms marked this pull request as ready for review May 18, 2023 20:39
@Hamms Hamms requested a review from a team as a code owner May 18, 2023 20:39
@Hamms Hamms requested review from a team and removed request for a team May 18, 2023 20:39
@Hamms Hamms merged commit 0054722 into staging May 22, 2023
2 checks passed
@Hamms Hamms deleted the pin-google-chrome-stable-version branch May 22, 2023 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants