Bump ml-playground version to fix dataset descriptions #51988
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dancodedotorg
approved these changes
May 18, 2023
daynew
approved these changes
May 19, 2023
breville
approved these changes
May 19, 2023
pablo-code-org
pushed a commit
that referenced
this pull request
May 25, 2023
snickell
pushed a commit
that referenced
this pull request
Feb 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Get updated ml-playground version to fix missing descriptions in some levels. Description text (potential uses, potential misuses) was missing prior to this change. After, this change, descriptions appear (see screenshot below):
Bug fix in ml-playground repo:
code-dot-org/ml-playground#301
Worth noting that this fix wasn't visible on the code-dot-org side until I manually ran
yarn build--yarn startdoes not seem to copy these static asset files. I wasn't able to easily determine why this was the case.Links
Testing story
Confirmed that the level reported as broken now shows dataset descriptions. Also confirmed a level with visible descriptions (
/s/csd7-2022/lessons/6/levels/4) continued to have visible descriptions.