[Google Blockly] Skip logging if workspace is readonly #51996
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the logging that was recently implemented for comparing blocks created from XML/JSON sources:
During the second round of the experiment this morning, we logged difference records for two types of cases:
generatedOptions_
was found to have increased in length by one when serializing with JSON. To allow us to see the specific values that are changing, we can stringify the actual object arguments being compared.For item 2, this would be expected to improve the clarity of certain records. Here's a hypothetical comparison for a difference found in the number of dropdown options in a block:
Before
After:
(Scroll to the right to see full strings. Note that the last option above is for illustrative purposes only. I haven't been able to repro the problem!)
Additional context on Slack: https://codedotorg.slack.com/archives/C03DBDN67B7/p1684504970060669
Links
Testing story
Deployment strategy
Follow-up work
Privacy
Security
Caching
PR Checklist: