Fix for TypeScript issues with yarn start

[sanchitmalhotra126]

This is a tentative fix for some intermittent issues we've been seeing with TypeScript and running yarn start. Specifically, we've noticed that occasionally TypeScript will fail to recognize the @cdo/apps path defined in tsconfig.json, saying the file does not exist, but only when running yarn start. When this occurs, we've noticed that yarn build succeeds.

The fix here is to remove the ts task from the list of watch tasks run during yarn start. I believe this was causing some issues where TypeScript was getting built too early/out of sync, and the webpack:watch step should take care of compiling TypeScript anyway.

I've also included some small test changes which updates JS import paths in a .tsx file from require to import. These changes were initially failing to build for me, but after updating the Gruntfile, they build successfully.

Links

https://codedotorg.atlassian.net/browse/SL-861

Testing story

Tested locally by first running yarn clean and manually deleting the .tscache folder. Then separately ran both yarn build and yarn start and confirmed that there were no build issues, and new changes were building.

[ebeastlake]

This change seems reasonable to me. I defer to @molly-moen for final approval!

[molly-moen]

Nice!

[breville]

and the webpack:watch step should take care of compiling TypeScript anyway.

Totally out of curiosity, where is this code that is doing the TypeScript compiling?

[sanchitmalhotra126]

Totally out of curiosity, where is this code that is doing the TypeScript compiling?

@breville I believe in our Webpack base config here. According to Webpack, ts-loader uses tsc (the TypeScript compiler)