Reapply "Puma with SystemD" #52368
Merged
Reapply "Puma with SystemD" #52368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Puma with SystemD
…ically at buildtime
cat5inthecradle
approved these changes
Jun 21, 2023
Hamms
added
the
Ruby Update
Merged
Hamms
added a commit
that referenced
this pull request
Oct 24, 2023
Follow-up to #52368 Now that all persistent managed servers have been cleaned up (slash recreated from scratch), we can remove the logic we temporarily added to perform that cleanup.
Hamms
added a commit
that referenced
this pull request
Oct 25, 2023
Follow-up to #52368 Now that all persistent managed servers have been cleaned up (slash recreated from scratch), we can remove the logic we temporarily added to perform that cleanup.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reapplies #52313, effectively reverting #52346
Our previous attempt failed because when I reimplemented the logic we used to have for creating the
/run/unicorndirectory in which we store sockets, I did so in Chef. Unfortunately, the/run/directory is ephemeral, and gets reset on reboot. This seemed fine in all my testing on adhocs and our deployment pipeline, but unfortunately the new frontend instances we spin up after building a new AMI are fresh boots, and so don't have that directory.The simple fix is to use SystemD rather than Chef to create the directory, just like we used to use SysV rather than Chef for it.
Links
Testing Story
Verified on an adhoc of this branch that we can successfully start up our web server services after a reboot. Verified on an adhoc of another branch that this fix can be successfully applied to existing instances.