-
Notifications
You must be signed in to change notification settings - Fork 481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rubric model assocations #52780
Rubric model assocations #52780
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't have any kind of has_many
association for Level.
Just confirming that we are certain that a lesson only has one rubric?
Oh good point. I can add that! |
@tess323 -- does this sound right to you? |
belongs_to :level | ||
belongs_to :lesson |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One thing I should've called out -- as written, both a lesson and a level are required. It's easy to mark them as optional but I want to check what feels right here. My working assumption has been that both are needed but I might be wrong there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The core reason why both would be required, to my understanding going in, would be because there could be more than one per lesson. but I guess we want both... since a level is absolutely required to be the point of assessment and then a lesson is loosely required for the purposes of lookup and showing it on the lesson page more easily.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, that was my thinking as well. I'll leave it as-is and as we work and potentially find reasons to adjust this, we can reconsider
yup! |
This all looks right to me |
Codifying my understanding of the model relations -- please comment if these don't seem right. I want to get these right before we go too much farther!
This understanding comes both from the tech spec and this slack conversation (apologies for this being in a private channel!).
The associations codified here are:
Rubric
belongs to aLesson
and aLevel
. (We may, in the future, need to know the unit, but that can be derived through lesson.)Rubric
has manyLearningGoal
and, inversely, aLearningGoal
belongs to aRubric
.LearningGoal
has manyLearningGoalEvidenceLevel
and, inversely, aLearningGoalEvidenceLevel
belongs to aLearningGoal
.LearningGoalEvaluation
belongs to aLearningGoal
. It will also have some associations with users in the future, but I haven't added those in this PR, preferring to focus only on the rubric side.