Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Curriculum Catalog Assignment Confirmation Message Cleanup #52847

Merged
merged 5 commits into from
Jul 24, 2023
Merged

Curriculum Catalog Assignment Confirmation Message Cleanup #52847

merged 5 commits into from
Jul 24, 2023

Conversation

TurnerRiley
Copy link
Contributor

This PR does 2 items of cleanup from this PR:

  • Clears the assignment confirmation message when the message is closed
  • Updates Curriculum Catalog UI tests to check that a successful assignment triggers the confirmation message on the page.

Links

Jira ticket: here

Testing story

Local testing and passing drone build.

PR Checklist:

  • Tests provide adequate coverage
  • Privacy and Security impacts have been assessed
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

@TurnerRiley TurnerRiley changed the base branch from staging to meg/assign-button-with-sections July 17, 2023 20:20
@TurnerRiley TurnerRiley requested a review from a team July 17, 2023 23:17
Base automatically changed from meg/assign-button-with-sections to staging July 19, 2023 14:38
@TurnerRiley TurnerRiley merged commit c9002ea into staging Jul 24, 2023
2 checks passed
@TurnerRiley TurnerRiley deleted the add-confirmation-message-catalog-ui-tests branch July 24, 2023 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidsbailey davidsbailey davidsbailey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@TurnerRiley @davidsbailey