Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Left aligned cards in rows with less than three cards #52925

Merged
merged 1 commit into from
Jul 24, 2023

Conversation

juanmanzojr
Copy link
Contributor

This PR Left aligns cards in rows where there are less than 3 cards showing.

One item in last row Full Screen:

Screenshot 2023-07-20 at 12 14 35 PM

Two items in last row Full Screen:

Screenshot 2023-07-20 at 12 21 16 PM

One item Last row Tablet View:

Screenshot 2023-07-20 at 12 15 35 PM

One item per row Mobile:

Screenshot 2023-07-20 at 12 16 04 PM

Links

Testing story

Local testing

PR Checklist:

  • Tests provide adequate coverage
  • Privacy and Security impacts have been assessed
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

@juanmanzojr juanmanzojr requested a review from a team July 20, 2023 19:24
@juanmanzojr juanmanzojr changed the title Left aligned cards with rows less than three Left aligned cards in rows with less than three cards Jul 20, 2023
Copy link
Contributor

@megcrenshaw megcrenshaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, but @kelbyhawn would you mind taking a look before Juan merges? Kelby knows much more about grid than I do!

@kelbyhawn
Copy link
Contributor

This looks great @juanmanzojr! 🙌

@juanmanzojr juanmanzojr merged commit 88ac9c8 into staging Jul 24, 2023
2 checks passed
@juanmanzojr juanmanzojr deleted the left-align-curriculum-catalog-cards branch July 24, 2023 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants