Music: support flyout toolbox #52941
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sanchitmalhotra126
approved these changes
Jul 21, 2023
| | http://studio.code.org/s/allthethings/lessons/46/levels/2 | music lab script level | | ||
| | http://studio.code.org/s/allthethings/lessons/46/levels/4 | music lab script level | |
There was a problem hiding this comment.
Should we change this to a standalone project URL (projects/music/new) so we don't need to worry about updating it if the allthethings progression changes?
There was a problem hiding this comment.
We depend on allthethings for much of our UI testing, so I think it's reasonable to keep these particular levels in sync with UI tests.
Comment on lines
9
to
12
| "toolbox": { | ||
| "Play": ["play_sound_at_current_location_simple2"] | ||
| }, | ||
| "simpleToolbox": true, |
There was a problem hiding this comment.
Minor: should we nest this inside the "toolbox" field? Something like
"toolbox": {
"blocks": { "Play": [...] },
"simple": true,
// alternatively
"type": "flyout" / "category"
}
There was a problem hiding this comment.
Good idea. I was opting for legacy compatibility, but we're still at the stage where we should build the ideal format, and this is closer to that!
sanchitmalhotra126
approved these changes
Jul 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for an optional Music Lab level property,
"type": "flyout", which will show a toolbox with all blocks shown all the time, without categories.It seems this could be helpful in early levels in a progression, when only a few blocks will be available.
The toolbox section of the level data has been changed a little, to have separate
"blocks"and optional"type"entries.flyout toolbox
categories toolbox (default)