DTL (Test > Levelbuilder): 7a54e0a4 #52942
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
> Checks for unintended or-assignment to a constant. > > Constants should always be assigned in the same location. And its value should always be the same. If constants are assigned in multiple locations, the result may vary depending on the order of `require`. Fix applied automatically with `bundle exec rubocop --auto-correct-all --only Lint/OrAssignmentToConstant` This may well be a Chesterton's Fence situation, because in neither case is it clear to me why we are using conditional assignment for these constants in the first place. I can't think of any reason why there would be, for the reasons pointed out in the description of the cop itself; I think it's likely these are just oversights, but want to call out that I'm not certain about that. - https://docs.rubocop.org/rubocop/cops_lint.html#lintorassignmenttoconstant - https://www.rubydoc.info/gems/rubocop/RuboCop/Cop/Lint/OrAssignmentToConstant
* Added Fixed Positioning of filters on curriculum catalog * Fixed padding issue * Fixed Padding and margin * Fixed Padding and Margin
DTT (Staging > Test) [robo-dtt]
* add chat to allthethings * convert to aichat * add level to allthethings locally * inherit from level * fix misnamed variables * support non blockly puzzle options * add default i18n file * modify levels-aichat-main * render using lab2 framework (#52730) * remove unnecessary UI and LevelData for now; remove unneeded console statements * update comments * remove unnecessary boilerplate * delete more unnecessary files * add missing level file * update to use LabViewsRenderer * add to types_without_ideal_level_source * add aichat to edit.html.haml * add log messages for debugging * simplify fields .html.haml file to pass unit test * fix path to aichat_fields haml file * remove log messages * remove more log messages * remove unnecessary white space * modify test level to match row
DTT (Staging > Test) [robo-dtt]
…nstant Fix Violations of and Reenable `Lint/OrAssignmentToConstant`
I18n sync Down and Out part 1/9
I18n sync Down and Out part 2/9
I18n sync Down and Out part 3/9
I18n Down and Out part 4/9
I18n Down and Out part 5/9
I18n Down and Out part 6/9
I18n Down and Out part 7/9
I18n Down and Out part 8/9
I18n Down and Out part 9/9
I18n sync In & Up 07/20
DTT (Staging > Test) [robo-dtt]
* Add indexes to rubric tables * Add an index on levels * Add better index and add not null constraints
DTT (Staging > Test) [robo-dtt]
* Add description,self-paced professional learning, professional learning program, video, and published date to course offerings * Fixed a name issue * Update course offering serialization to serialize new fields * Update course offering serialization to serialize new fields * Updated course offering serialize test * Added fields to summarize for edit function * Added Description Field to editor * Added new fields to course offering editor * Added new fields to test * Fixed Prop Types and added Self Paced PL Course Offering prop to test * Added ID to Self Paced PL Course Offering prop * Removed Self Paced Professional Learning field in editor and test file in preparation for data type change * Added Dropdown list for Professional learning programs * Changed Workshop names * Added new props to Test file * Refactored Script data retrieval * Added correct data for test * Renamed model method
DTT (Staging > Test) [robo-dtt]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.