Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix German and Arabic staggered steps #52946

Merged
merged 1 commit into from
Jul 24, 2023
Merged

fix German and Arabic staggered steps #52946

merged 1 commit into from
Jul 24, 2023

Conversation

elf-code
Copy link
Contributor

It seems like the translations for the function name for German and Arabic have "\n" in them so weren't getting parsed by the XML correctly (from my guesses), removing the "\n"s fixes the issue.

My editor also reformatted a lot of empty objects, but @carl-codeorg 's update to the sync out should remove those in the next pass, I think.

I am not positive that these won't get replaced by the next sync.

Links

Jira ticket - https://codedotorg.atlassian.net/browse/P20-322

Testing story

Before:
Screenshot 2023-07-21 at 9 16 31 AM

After:
Screenshot 2023-07-21 at 12 03 09 PM

PR Checklist:

  • Tests provide adequate coverage
  • Privacy and Security impacts have been assessed
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

@elf-code elf-code requested a review from a team as a code owner July 21, 2023 19:11
Copy link
Contributor

@carl-codeorg carl-codeorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@mgc1194 mgc1194 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done. Is this a json parses issue or are this \n in Crowdin as well?

@elf-code
Copy link
Contributor Author

elf-code commented Jul 24, 2023

Huddled w/ Mario to update the strings in Crowdin - note to future updaters, be sure to update the "master string" first when there are duplicates.

Drone was failing w/ a flaky test, but it's not testing the translated strings.

@elf-code elf-code merged commit 621ca24 into staging Jul 24, 2023
1 of 2 checks passed
@elf-code elf-code deleted the elf-p20-322 branch July 24, 2023 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants